Review Request 125321: KSycoca: ensureCacheValid() should create the db if it doesn't exist

David Faure faure at kde.org
Sun Sep 20 11:43:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125321/
-----------------------------------------------------------

Review request for KDE Frameworks and Albert Astals Cid.


Repository: kservice


Description
-------

and should work even if this process hasn't opened the DB yet.
E.g. kded will do this on startup.

The NoDatabase/DatabaseNotOpen distinction created bugs, merge the two.

The openDummyIfNotFound argument was useless in the new code, removed it.


Diffs
-----

  autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 
  src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 
  src/sycoca/ksycoca_p.h 72ba397007c72c7e8731bfab6be95ad5633774aa 

Diff: https://git.reviewboard.kde.org/r/125321/diff/


Testing
-------

extended ksycocatest


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150920/0f4e5608/attachment.html>


More information about the Kde-frameworks-devel mailing list