Review Request 125318: KBuildSycocaProgressDialog: use Qt's builtin busy indicator.

[Sune Vuorela]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125318/#review85681
-----------------------------------------------------------


If we can't determine the time, then yes, let's use the 'infinite spinner' instead of fake calculations.

I'm not sure I'm enough into the kservice code to actually give a shipit, so I'll refrain from that.

- Sune Vuorela


On Sept. 19, 2015, 10:58 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125318/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 10:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This makes the code much simpler and looks better to the user
> than a fake progress.
> 
> Also removed the 1s delay before closing the dialog.
> Users like fast, not slow ;)
> 
> BUG: 158672
> Change-Id: I4a5cc975239d5c2998cdc3079890834c23ae677d
> REVIEW: 125318
> FIXED-IN: 5.15
> 
> 
> Diffs
> -----
> 
>   src/widgets/kbuildsycocaprogressdialog.h 88c5087990c01725e065fc650e63de246b3032e1 
>   src/widgets/kbuildsycocaprogressdialog.cpp 78d23dfda174f195e4c7fdfc1e128e83194326f3 
> 
> Diff: https://git.reviewboard.kde.org/r/125318/diff/
> 
> 
> Testing
> -------
> 
> kio/tests/ksycocaupdatetest, after deleting ksycoca so that it doesn't end too fast ;)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150920/7b4a51d8/attachment.html>