Review Request 125290: Refresh Solid's device list before querying in kio_trash

[Bartosz Sławianowski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125290/
-----------------------------------------------------------

(Updated Sept. 19, 2015, 7:14 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Added comments on why it's exactly needed and using qApp instead of QEventLoop


Repository: kio


Description
-------

We need to process events in Qt event loop before querying Solid's device list. Solid caches devices and relies on signals to refresh them (at the very least that's how fstab backend works) which is a problem if kio_trash process is reused.

Currently if kio_trash process is reused and there were some device changes (for example new NFS share was mounted) kio_trash will fail to choose valid trash directory for "trashing" file - or fail to find all trash directories (in case of list action). Next reuse of the same process would actually succeed because TrashImpl::move (which is called later in the process of trashing file) enters the loop.


Diffs (updated)
-----

  src/ioslaves/trash/trashimpl.cpp 5a2832a 
  src/ioslaves/trash/trashimpl.h 9881d8e 

Diff: https://git.reviewboard.kde.org/r/125290/diff/


Testing
-------

Arch Linux


Thanks,

Bartosz Sławianowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150919/91eb783d/attachment-0001.html>