Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

[Albert Astals Cid]

> On set. 19, 2015, 3:47 p.m., David Faure wrote:
> > Hmmm... and then old-kded crashed. You can't mmap a symlink? 
> > 
> > #10 0x00007f6b0c76d6d4 in qt_assert(char const*, char const*, int) (assertion=0x7f6b0d69fbbf [...] "canRead", file=[...] "/d/kde/src/5/frameworks/kservice/src/sycoca/ksycoca.cpp", line=125) at global/qglobal.cpp:2966
> > #11 0x00007f6b0d6607d7 in KSycocaPrivate::tryMmap() (this=0x1a5d840) at /d/kde/src/5/frameworks/kservice/src/sycoca/ksycoca.cpp:120

Does a hardlink instaead of a symlink work?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125279/#review85670
-----------------------------------------------------------


On set. 19, 2015, 3:43 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125279/
> -----------------------------------------------------------
> 
> (Updated set. 19, 2015, 3:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> This will prevent sycoca-rebuild ping-pong if two apps with different settings
> would share the same file (and keep finding that it's wrong for them),
> and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German
> translations for the strings coming from desktop files.
> 
> REVIEW: 125279
> 
> 
> Diffs
> -----
> 
>   src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 
>   autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 
>   docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook d7f85813b1956b578600b4fbd147b3ac649b470c 
>   src/sycoca/ksycoca.h a78e90876ed758093070989ab166959e0ea6c0e3 
>   src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 
> 
> Diff: https://git.reviewboard.kde.org/r/125279/diff/
> 
> 
> Testing
> -------
> 
> unittests, after adjusting ksycocatest which was checking for the old behavior (same file).
> 
> Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews!
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150919/41970267/attachment.html>