Review Request 125314: KBuildSycocaProgressDialog: run kbuildsycoca5 with QProcess.

David Faure faure at kde.org
Sat Sep 19 15:05:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125314/
-----------------------------------------------------------

Review request for KDE Frameworks and Albert Astals Cid.


Bugs: 166792
    https://bugs.kde.org/show_bug.cgi?id=166792


Repository: kio


Description
-------

The dbus-callback stuff from kded is unreliable and unnecessary.

And meanwhile I made kbuildsycoca5 work well when called more
than once, the second instance will wait for the first one
and then check if there's anything else to do, otherwise quit early.

Change-Id: I24f62cf1015bdbab1778245f4221f03f40a9bd0f
BUGS: 235486, 166792
FIXED-IN: 5.15


Diffs
-----

  src/widgets/kbuildsycocaprogressdialog.cpp 78d23dfda174f195e4c7fdfc1e128e83194326f3 

Diff: https://git.reviewboard.kde.org/r/125314/diff/


Testing
-------

kpropertiesdialogtest <path to app desktop file>, changing the comment, clicking OK.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150919/e7c6f67e/attachment.html>


More information about the Kde-frameworks-devel mailing list