Review Request 125275: KSycoca: remove all self() methods for factories, store them in KSycoca instead.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125275/#review85600
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On set. 16, 2015, 11:13 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125275/
> -----------------------------------------------------------
> 
> (Updated set. 16, 2015, 11:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> This removes the whole template magic and QThreadStorage for each factory,
> and goes to a more object oriented design where the factories belong to
> a ksycoca instance (= one per thread, plus one for rebuilding).
> 
> This even makes it possible to create another ksycoca instance with its
> own factories, for special unittests (coming up).
> 
> 
> Diffs
> -----
> 
>   autotests/kmimeassociationstest.cpp 5550938abe4d9c9c1ee698ac1b225312690e4aa6 
>   src/services/kmimetypefactory.cpp ba07aa0bc9b5d528454cf426b1feadb049402123 
>   src/services/kmimetypetrader.cpp 702ef2913d3e218f53bb8b935e3d5ea19d66f7cc 
>   src/services/kplugininfo.cpp 93dcb8fc35930d89e4e60efea755b018d329794f 
>   src/services/kservice.cpp 045a2dad2775decf6bf427873b9fd1e292a1fe87 
>   src/services/kservicefactory.cpp 9b0e0c199818fea774c08a4f8fab5aca417927c8 
>   src/services/kservicegroup.cpp 50eed4a5c4d1917ce9a9d4a3ed617a5749b122d3 
>   src/services/kservicegroupfactory.cpp 08e0bdcd765ab08afdb71cabc640fd21a73f4218 
>   src/services/kservicetype.cpp 0ad453937d892d55725401dba024f95b95e91405 
>   src/services/kservicetypefactory.cpp 62fd230b4f7a6558c707d257796c5967f39c3607 
>   src/services/kservicetypeprofile.cpp e4953a6333d044b77f983705036409a25c4fcb1c 
>   src/services/kservicetypetrader.cpp ca964e920bd7a9e0e6ab901d99b713b7ea7d3de3 
>   src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 
>   src/sycoca/kbuildsycoca_p.h c24413398694de29a788dd9498435572f5f605a3 
>   src/sycoca/ksycoca.h c561dfd1550fd28e73144af6d3b2fa9008b17f59 
>   src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 
>   src/sycoca/ksycoca_p.h a86148a20fccf038e2d46f5d2d6d460be94910da 
>   src/sycoca/ksycocafactory_p.h c54bfc7b1ce917f11b6451f30863b374f2d94eb3 
>   src/sycoca/vfolder_menu.cpp b17ef2d371a2804ebe6029a0b7abfbebe4298d50 
>   src/sycoca/vfolder_menu_p.h b90f5efad903b73cbea7b40c142cc9e55e8c5bed 
> 
> Diff: https://git.reviewboard.kde.org/r/125275/diff/
> 
> 
> Testing
> -------
> 
> ctest (3 times)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150917/5d58ee67/attachment-0001.html>