Review Request 125274: KBuildSycoca: remove writing of the ksycoca5stamp file.

Albert Astals Cid aacid at kde.org
Thu Sep 17 22:18:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125274/#review85594
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On set. 17, 2015, 12:01 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125274/
> -----------------------------------------------------------
> 
> (Updated set. 17, 2015, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> The code for reading it was already removed as part of b0c8fd8e64f,
> the removal of the --checkstamps option.
> 
> The feature still exists anyway, a timestamp of "at least everything until
> that time is in the DB" is in the sycoca header, and it used by the timestamp
> check in ksycoca.cpp. This was an unnecessary separate file.
> 
> REVIEW: 125274
> 
> 
> Diffs
> -----
> 
>   src/sycoca/kbuildsycoca.cpp a009d62f24da093988066e8850f9ace5d6f0766d 
>   docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook 3419e42cb29c6699bc17e6dd46bbc523139c59eb 
> 
> Diff: https://git.reviewboard.kde.org/r/125274/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150917/ca0196f4/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list