Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

Jan Grulich jgrulich at redhat.com
Thu Sep 17 14:14:32 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125289/
-----------------------------------------------------------

(Updated Sept. 17, 2015, 2:14 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Ivan Romanov.


Changes
-------

Submitted with commit 66b9754170759d9333d5fc1e348642814d0310dd by Jan Grulich to branch master.


Repository: qca


Description
-------

This is used also in other header files from include folder. I'm trying to use QCA in plasma-nm, but I have to use - add_definitions(-DQT_NO_KEYWORDS) in CMake due to NetworkManager and thus plasma-nm will not compile with QCA if signals/slots are used.


Diffs
-----

  include/QtCrypto/qca_safetimer.h 68dde5c 

Diff: https://git.reviewboard.kde.org/r/125289/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150917/dac6fd04/attachment.html>


More information about the Kde-frameworks-devel mailing list