Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Sep 17 13:30:35 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125289/#review85574
-----------------------------------------------------------
+1 this was a problem in KDE Connect as well.
- Aleix Pol Gonzalez
On Sept. 17, 2015, 2:26 p.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125289/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 2:26 p.m.)
>
>
> Review request for KDE Frameworks and Ivan Romanov.
>
>
> Repository: qca
>
>
> Description
> -------
>
> This is used also in other header files from include folder. I'm trying to use QCA in plasma-nm, but I have to use - add_definitions(-DQT_NO_KEYWORDS) in CMake due to NetworkManager and thus plasma-nm will not compile with QCA if signals/slots are used.
>
>
> Diffs
> -----
>
> include/QtCrypto/qca_safetimer.h 68dde5c
>
> Diff: https://git.reviewboard.kde.org/r/125289/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150917/01cb2295/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list