Review Request 125226: move EventForge from the desktop containment
Marco Martin
notmart at gmail.com
Thu Sep 17 10:40:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
-----------------------------------------------------------
(Updated Sept. 17, 2015, 10:40 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Plasma and Eike Hein.
Changes
-------
Submitted with commit 133e534b7dfa29f2f39d227ed12a3d9bc04ccb8e by Marco Martin to branch master.
Repository: kdeclarative
Description
-------
EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.
API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)
Diffs
-----
src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f
src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp PRE-CREATION
src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h PRE-CREATION
src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1
Diff: https://git.reviewboard.kde.org/r/125226/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150917/eae17971/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list