Review Request 125270: KBuildSycoca: use qCWarning rather than fprintf(stderr, ...) or qWarning

Aleix Pol Gonzalez aleixpol at kde.org
Thu Sep 17 10:38:33 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125270/#review85554
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Sept. 17, 2015, 8:36 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125270/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 8:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> REVIEW: 125270
> 
> 
> Diffs
> -----
> 
>   src/sycoca/kbuildservicefactory.cpp bebb76947672d0e2c100c7149c642406c30355f1 
>   src/sycoca/kbuildservicegroupfactory.cpp 6ac0fc491f42bb117954ba8488b2847c8954e6b3 
>   src/sycoca/kbuildservicetypefactory.cpp 2610c8d99beb12e02070365b078deb4455a6472a 
>   src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 
>   src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 
>   src/sycoca/ksycocadict.cpp e90969c9acb7ef94ae8da2098400c7207e0aeb67 
>   src/sycoca/ksycocafactory.cpp bc55fb54f0836f492ad04519ca1c9f93e9af3880 
>   src/sycoca/vfolder_menu.cpp b17ef2d371a2804ebe6029a0b7abfbebe4298d50 
> 
> Diff: https://git.reviewboard.kde.org/r/125270/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150917/b751fa6a/attachment.html>


More information about the Kde-frameworks-devel mailing list