Review Request 125270: KBuildSycoca: use qWarning rather than fprintf(stderr, ...)
David Faure
faure at kde.org
Thu Sep 17 06:30:49 UTC 2015
> On Sept. 16, 2015, 11:46 p.m., Aleix Pol Gonzalez wrote:
> > Shouldn't it be qCWarning?
I'm not sure what's the use case for turning off error messages like "couldn't rebuild ksycoca, disk full?", but OK, let's be consistent ;)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125270/#review85529
-----------------------------------------------------------
On Sept. 16, 2015, 9:16 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125270/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 9:16 p.m.)
>
>
> Review request for KDE Frameworks and Albert Astals Cid.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> It's just more compact.
> And the message was wrong, too, it was showing "kbuildsycoca5", while
> this code is now in the lib.
>
>
> Diffs
> -----
>
> src/sycoca/kbuildsycoca.cpp 2afb8b5a6f2516b87dde73e7bf9af0348a962f43
>
> Diff: https://git.reviewboard.kde.org/r/125270/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150917/481e2405/attachment.html>
More information about the Kde-frameworks-devel
mailing list