Review Request 125278: KSycoca: add a q pointer to remove more singleton usage
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Sep 16 23:52:38 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125278/#review85533
-----------------------------------------------------------
+1
- Aleix Pol Gonzalez
On Sept. 17, 2015, 1:28 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125278/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 1:28 a.m.)
>
>
> Review request for KDE Frameworks and Albert Astals Cid.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> This change is needed for an upcoming unittest which needs to create
> another KSycoca instance.
>
>
> Diffs
> -----
>
> src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7
> src/sycoca/ksycoca_p.h a86148a20fccf038e2d46f5d2d6d460be94910da
>
> Diff: https://git.reviewboard.kde.org/r/125278/diff/
>
>
> Testing
> -------
>
> ctest.
>
> Albert: don't despair, this is the one-before-last patch ;)
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/3ca2ff34/attachment.html>
More information about the Kde-frameworks-devel
mailing list