Review Request 125214: Add support for network shares in kio_trash

[Bartosz Sławianowski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125214/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 10:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit a7871885046394d577eeea8fa8991d30a046545f by David Faure on behalf of Bartosz S?awianowski to branch master.


Bugs: 177023
    https://bugs.kde.org/show_bug.cgi?id=177023


Repository: kio


Description
-------

kio_trash doesn't support network shares, causing "trashed" files to be copied into user's home directory.

This patch adds support for them by assigning them persistent ID's (because there is no device minor/major ID or any other integer we can use) which are stored in trashrc config file - because we need to share them between possible multiple kio_trash processes.

Network shares get ID's starting with 6000000 to avoid possible conflicts with block devices.

NextID is also stored in trashrc file, I guess I could drop it by simply using group.keyList().count() or iterating all entries and finding max ID. Need opinions 

Thought about using different config file to avoid adding mutable modifier to m_config, need opinions here as well

Also using KInterProcessLock which already was there instead of adding dependency on KDbusAddons framework


Diffs
-----

  src/ioslaves/trash/trashimpl.h cee9278 
  src/ioslaves/trash/trashimpl.cpp 300d320 

Diff: https://git.reviewboard.kde.org/r/125214/diff/


Testing
-------

Arch Linux, few simple localhost NFS shares


Thanks,

Bartosz Sławianowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/581ef7bf/attachment-0001.html>