Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

Frank Reininghaus frank78ac at googlemail.com
Wed Sep 16 21:01:44 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125268/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 9:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit 689fd43ae226ad026dd2fb6e198a5fef40c24b13 by Frank Reininghaus to branch master.


Bugs: 352770
    https://bugs.kde.org/show_bug.cgi?id=352770


Repository: kio


Description
-------

Currently, the buttons in the dialog that is shown when trying to create a hidden directory (e.g., by pressing F10 in Dolphin and then entering a name that starts with a dot) do not work. This is because the slots are connected to the 'accepted' and 'rejected' signals of the QDialog. Actually, these signals are emitted by the QDialogButtonBox.


Diffs
-----

  src/filewidgets/knewfilemenu.cpp 2e8f9c6 

Diff: https://git.reviewboard.kde.org/r/125268/diff/


Testing
-------

Both buttons in the dialog work now: it is possible to create hidden directories, and it is also possible to choose a new name.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/f512bc59/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list