Review Request 125253: KSycoca: move all of the kbuildsycoca code into the lib, except for main().

Albert Astals Cid aacid at kde.org
Wed Sep 16 20:18:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125253/#review85512
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On set. 16, 2015, 7:15 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125253/
> -----------------------------------------------------------
> 
> (Updated set. 16, 2015, 7:15 a.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> This will allow, in a next step, to rebuild the cache without calling
> an external binary.
> 
> This change allows to export less classes from the lib, just for kbuildsycoca5's benefits
> (of course KBuildSycoca itself must be exported).
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt e06f3e80f6b8bf8e894fac971454bae121451b90 
>   src/CMakeLists.txt a82d260f7d6e4b9050aa0bb2bf70bac94ffc12cf 
>   src/kbuildsycoca/CMakeLists.txt d29963cb9bc1ee6c89668c669b01f5429db99d48 
>   src/kbuildsycoca/applications.menu  
>   src/kbuildsycoca/kbuildmimetypefactory.cpp  
>   src/kbuildsycoca/kbuildmimetypefactory_p.h  
>   src/kbuildsycoca/kbuildservicefactory.cpp  
>   src/kbuildsycoca/kbuildservicefactory_p.h  
>   src/kbuildsycoca/kbuildservicegroupfactory.cpp  
>   src/kbuildsycoca/kbuildservicegroupfactory_p.h  
>   src/kbuildsycoca/kbuildservicetypefactory.cpp  
>   src/kbuildsycoca/kbuildservicetypefactory_p.h  
>   src/kbuildsycoca/kbuildsycoca.cpp  
>   src/kbuildsycoca/kbuildsycoca_p.h 61d52a453d30a3c6d8b0d77995244f3628bdc463 
>   src/kbuildsycoca/kbuildsycocainterface_p.h  
>   src/kbuildsycoca/kctimefactory.cpp  
>   src/kbuildsycoca/kctimefactory_p.h  
>   src/kbuildsycoca/kmimeassociations.cpp  
>   src/kbuildsycoca/kmimeassociations_p.h  
>   src/kbuildsycoca/ksycocaresourcelist_p.h  
>   src/kbuildsycoca/vfolder_menu.cpp  
>   src/kbuildsycoca/vfolder_menu_p.h  
>   src/services/kmimetypefactory_p.h 299c9700a107d471e847e681f349d531170c580f 
>   src/services/kservicefactory_p.h 35dcf9a9df8903fd3c33ef7910860991c9e20463 
>   src/services/kservicegroupfactory_p.h 09ffd18949d42b0abc688619c45aa0b729730e7f 
>   src/services/kservicetypefactory_p.h 520f7f8ad365f055191e3902cedc09b8659c95d0 
>   src/sycoca/kmemfile_p.h 2aa9cb11b4b112085c347d3cc823473c5926f09e 
>   src/sycoca/ksycocafactory_p.h e2f5e839d251dff094bd526ead95319c5afb0a53 
>   src/sycoca/ksycocautils_p.h 6110ea8a9bd62552eb07a92f2f9eb482a6cde897 
> 
> Diff: https://git.reviewboard.kde.org/r/125253/diff/
> 
> 
> Testing
> -------
> 
> make, make install, make tests, kbuildsycoca5.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/3f4c911e/attachment.html>


More information about the Kde-frameworks-devel mailing list