Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Kurt Hindenburg]

> On Sep 16, 2015, at 2:54 AM, David Faure <faure at kde.org> wrote:
> 
> On Tuesday 15 September 2015 22:50:50 Kurt Hindenburg wrote:
>> 
>>> On Sep 15, 2015, at 2:07 PM, Marko Käning <mk-lists at mailbox.org> wrote:
>>> 
>>> Hi kdesignerplugin devs,
>>> 
>>> On 14 Sep 2015, at 15:00 , Kurt Hindenburg <kurt.hindenburg at gmail.com> wrote:
>>>> 
>>>> It appears the  QT_VERSION check in d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd is not enough when using Qt 5.4.x
>>> 
>>> anyone out there who can fix kdesignerplugin regarding this version check so that the next KF5 release is build-able again on Qt 5.4.x?
>>> 
>> If I read the Qt moc docs correctly, moc can’t expand macros.  So it never actually handles the #if.
>> 
>> The quick and dirty hack is to put the #if outside the static const, which means duplicating most of the static const.  It works here for Qt 5.4.x.  There is likely a more elegant way of doing it.
> 
> Try this:
> #if QT_VERSION >= 0x050500
> 

Thanks, that works for Qt 5.4.x; I don’t have a Qt5 install to check that.  Should I commit or do a review-board item?

-                                    "#if QT_VERSION >= QT_VERSION_CHECK(5, 5, 0)\n"
+                                    "#if QT_VERSION >= 0x050500\n"

  Kurt

> — 

> David Faure, faure at kde.org <mailto:faure at kde.org>, http://www.davidfaure.fr <http://www.davidfaure.fr/>
> Working on KDE Frameworks 5

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/cb0921da/attachment.html>