Review Request 125237: Change KKeyserver (x11) to categorized logging

Martin Gräßlin mgraesslin at kde.org
Wed Sep 16 06:13:44 UTC 2015



> On Sept. 15, 2015, 5:35 p.m., Martin Klapetek wrote:
> > src/platforms/xcb/kkeyserver.cpp, line 26
> > <https://git.reviewboard.kde.org/r/125237/diff/1/?file=403387#file403387line26>
> >
> >     If you put <QDebug> into "debug_p.h", then you'll have only one debug include instead of two everywhere

yeah I know. But I didn't want to change unrelated code ;-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125237/#review85451
-----------------------------------------------------------


On Sept. 15, 2015, 11:40 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125237/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 11:40 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Introduces a dedicated logging category for the kkeyserver.
> 
> 
> Diffs
> -----
> 
>   src/debug_p.h cb3c5492ef416385eb774c13308f654b0a71a350 
>   src/debug_p.cpp 4a1dd75786cd18c54c24abf5908c515ed6123ce2 
>   src/platforms/xcb/kkeyserver.cpp 6cfaa8962f6873fa8d34441b6b784eca4ba9b776 
> 
> Diff: https://git.reviewboard.kde.org/r/125237/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/cc240f05/attachment.html>


More information about the Kde-frameworks-devel mailing list