Review Request 125252: Clean X11/XCB detection

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125252/#review85477
-----------------------------------------------------------


can you please ensure whether kwindowsystem can be built that way? There is the kkeyserver which has compile time switched classes and OSX and X11 are mutual exclusive. It might be that the build system for OSX is just broken and it doesn't build. But we should make sure that we don't introduce now a problem for when OSX gets the build system eventually fixed.

- Martin Gräßlin


On Sept. 16, 2015, 1:23 a.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125252/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 1:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Put X11 and XCB at the same level outside APPLE if block.
> That way if one wants to try building with X11 on OS X it possible.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7561abeb280a1504f33714e8da5a141654c7b63f 
> 
> Diff: https://git.reviewboard.kde.org/r/125252/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/75f9c111/attachment.html>