Review Request 125243: Trivial CMake corrections for Baloo

Vishesh Handa me at vhanda.in
Tue Sep 15 21:27:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125243/#review85460
-----------------------------------------------------------

Ship it!


Ship It!

- Vishesh Handa


On Sept. 15, 2015, 5:15 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125243/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 5:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> 1) Be explicit about which modules are required
> 2) Find dependancies as the rest of KF5 ecosystem
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d419b91 
>   KF5BalooConfig.cmake.in cc0f543 
>   src/file/CMakeLists.txt 0b5d1d9 
> 
> Diff: https://git.reviewboard.kde.org/r/125243/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150915/3e4bb201/attachment.html>


More information about the Kde-frameworks-devel mailing list