Review Request 125226: move EventForge from the desktop containment

Marco Martin notmart at gmail.com
Tue Sep 15 17:32:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 5:32 p.m.)


Review request for KDE Frameworks, Plasma and Eike Hein.


Changes
-------

fix the logic


Repository: kdeclarative


Description
-------

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150915/a8453295/attachment.html>


More information about the Kde-frameworks-devel mailing list