Review Request 125218: Fix memory leaks in the KBuildSycoca class

[David Faure]

> On Sept. 13, 2015, 9:34 p.m., Albert Astals Cid wrote:
> > src/kbuildsycoca/kbuildsycoca.cpp, line 482
> > <https://git.reviewboard.kde.org/r/125218/diff/1/?file=403161#file403161line482>
> >
> >     Worth resetting to 0?

It's set to 0 (or to something) at the beginning of recreate(), so if we ever reuse a kbuildsycoca instance to call recreate() twice (which is probably not really supported right now), it would still be fine.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125218/#review85335
-----------------------------------------------------------


On Sept. 13, 2015, 8:53 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125218/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2015, 8:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> It will soon be part of the library, so these leaks will be much more problematic
> 
> 
> Diffs
> -----
> 
>   src/kbuildsycoca/kbuildsycoca.cpp 731045907ee356dfea20f5e37ddb968d66a181bc 
>   src/kbuildsycoca/vfolder_menu.cpp fb1a6ef9da53b0ed400f212c939a4616f9e80398 
> 
> Diff: https://git.reviewboard.kde.org/r/125218/diff/
> 
> 
> Testing
> -------
> 
> QT_ENABLE_REGEXP_JIT=0 QT_NO_GLIB=1 valgrind --tool=memcheck --leak-check=yes kbuildsycoca5
> 
> is now clean (apart from tons of gobject stuff, despite the QT_NO_GLIB=1... there must be a plugin somewhere)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150913/240ff6c9/attachment.html>