Review Request 125214: Add support for network shares in kio_trash
Bartosz Sławianowski
eplightning at outlook.com
Sun Sep 13 19:59:15 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125214/
-----------------------------------------------------------
Review request for KDE Frameworks and David Faure.
Bugs: 177023
https://bugs.kde.org/show_bug.cgi?id=177023
Repository: kio
Description
-------
kio_trash doesn't support network shares, causing "trashed" files to be copied into user's home directory.
This patch adds support for them by assigning them persistent ID's (because there is no device minor/major ID or any other integer we can use) which are stored in trashrc config file - because we need to share them between possible multiple kio_trash processes.
Network shares get ID's starting with 6000000 to avoid possible conflicts with block devices.
NextID is also stored in trashrc file, I guess I could drop it by simply using group.keyList().count() or iterating all entries and finding max ID. Need opinions
Thought about using different config file to avoid adding mutable modified to m_config, need opinions here as well
Also using KInterProcessLock which already was there instead of adding dependency on KDbusAddons framework
Diffs
-----
src/ioslaves/trash/trashimpl.h cee9278
src/ioslaves/trash/trashimpl.cpp 300d320
Diff: https://git.reviewboard.kde.org/r/125214/diff/
Testing
-------
Arch Linux, few simple localhost NFS shares
Thanks,
Bartosz Sławianowski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150913/8a21c63c/attachment.html>
More information about the Kde-frameworks-devel
mailing list