Review Request 125211: [autotests] don't delete in one thread a service that another thread is querying.

Albert Astals Cid aacid at kde.org
Sun Sep 13 17:23:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125211/#review85321
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On set. 13, 2015, 4:24 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125211/
> -----------------------------------------------------------
> 
> (Updated set. 13, 2015, 4:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> A comment said to not use fakeservice.desktop in other tests, and yet another
> test method (run in parallel by testThreads()) was doing that.
> 
> -> separate fakeservice.desktop (used for querying) and fakeservice_deleteme.desktop
> (used for deleting + recreating)
> 
> 
> Diffs
> -----
> 
>   autotests/kservicetest.h 9c92e23fc5873787ab62a8c7170a33852d19aa34 
>   autotests/kservicetest.cpp afaf20d33c31f83036ecba4f65e8f0073bf015df 
> 
> Diff: https://git.reviewboard.kde.org/r/125211/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150913/2f3c1dcf/attachment.html>


More information about the Kde-frameworks-devel mailing list