Review Request 125158: add logic to use icons for default xdg user dirs

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125158/
-----------------------------------------------------------

(Updated Sept. 12, 2015, 1:29 p.m.)


Review request for KDE Frameworks.


Changes
-------

new approach as suggested by Frank, flattening out the map once and then simply doing a key lookup on it.
this has the unfortunate side effect that runtime changes to the paths config (as seen in our paths KCM) will not get picked up until after application restart. BUT given that this feature is not exactly required and these paths usually do not get changed often by the user, we are probably better served ignoring this downside (the other options would be dbus glueing to the kcm or making qstandardpaths qfilesystemwatch...)


Bugs: 352498
    https://bugs.kde.org/show_bug.cgi?id=352498


Repository: kio


Description (updated)
-------

this acts as an additional fallback to mimetype iconing and .directory
overrides. xdg user dirs are relocatable and can change depending on user
locale as well as user configuration and additionally are used in a range
of different desktop environments making this a very runtime sort of
decision.

BUG: 352498


Diffs (updated)
-----

  autotests/kfileitemtest.h 615324f2b45fdc90a7841bdd0c8aa7f47cdf57a2 
  autotests/kfileitemtest.cpp 5f728a411401fe3009924b66970d9ae6f12c60f2 
  src/core/kfileitem.cpp 966d8626708a8f2672f1777c873f4e27e13023d6 

Diff: https://git.reviewboard.kde.org/r/125158/diff/


Testing
-------

maked
autotested
installed
dolphin and file open dialogs now show icons


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150912/b5859f5c/attachment-0001.html>