Review Request 125184: KSycoca: rename private slot to avoid ambiguity with DBus signal

David Edmundson david at davidedmundson.co.uk
Sat Sep 12 10:20:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125184/#review85242
-----------------------------------------------------------


+1

- David Edmundson


On Sept. 12, 2015, 8:28 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125184/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 8:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> It didn't create any actual trouble, but I was debugging a bug with
> very weird symptoms related to that DBus signal so I wanted to make sure
> this wasn't the issue (turns out it was kbuildsycoca running one time too many).
> 
> 
> Diffs
> -----
> 
>   src/sycoca/ksycoca.h 9d8b21e3c0f08375bece923c4029b54617f04b7f 
>   src/sycoca/ksycoca.cpp 36718e3ee951df19494031f17dec29d1f4dd39c5 
> 
> Diff: https://git.reviewboard.kde.org/r/125184/diff/
> 
> 
> Testing
> -------
> 
> unittests still pass
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150912/05e73fde/attachment.html>


More information about the Kde-frameworks-devel mailing list