Review Request 125185: kbuildsycoca: move sending of DBus signal to the KBuildSycoca class

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125185/#review85237
-----------------------------------------------------------


Ben Cooksley had an interesting suggestion: instead of sending a DBus signal, we could make KSycoca use QFileSystemWatcher to detect when sycoca has been updated, and emit the Qt signal then.

The only downside is that we wouldn't be able to ship the list of changed resources, so we would have to emit
databaseChanged({"services", "servicetypes", "xdgdata-mime", "apps"}) every time it's changed. But that should be fine imho, most apps only check for "apps", and that's emitted anyway due to a bug that's been there forever.

- David Faure


On Sept. 12, 2015, 8:36 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125185/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 8:36 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> When this code moves to the lib, the app doing the rebuilding should
> emit the signal.
> 
> 
> Diffs
> -----
> 
>   src/kbuildsycoca/kbuildsycoca_p.h 1be91bf21bb6908a63ffe6c156830838ed1ff429 
>   src/kbuildsycoca/kbuildsycoca_main.cpp 5a0c0e8b47996750a1bf25139e1c21eb0392044b 
>   src/kbuildsycoca/kbuildsycoca.cpp 2a1c6b3e2ef2add82f710e1a18cf77028f437407 
> 
> Diff: https://git.reviewboard.kde.org/r/125185/diff/
> 
> 
> Testing
> -------
> 
> unittests still pass
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150912/929b96ac/attachment-0001.html>