Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

[Xuetian Weng]

> On Sept. 11, 2015, 10:02 a.m., Luca Beltrame wrote:
> > +1
> 
> Jean-Baptiste Mardelle wrote:
>     Kdenlive is also affected by this issue, as described in bug #346413
>     Pressing "Esc" allows to dismiss the invisible file dialog and regain control of the app.
>     However I tested the proposed patch and it does not solve the problem for me...

Hi, you did remind me that I also hit this on kdenlive. But it seems that this does fix for kdenlive. I tried ctrl+o dialog and was not able to reproduce it.

Can you confirm that you install your new frameworkintegration to the correct path?


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125154/#review85165
-----------------------------------------------------------


On Sept. 11, 2015, 8:28 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125154/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 8:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Lukáš Tinkl.
> 
> 
> Bugs: 350758
>     https://bugs.kde.org/show_bug.cgi?id=350758
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> In https://bugs.kde.org/show_bug.cgi?id=334963 Cjacker proposed a patch.
> 
> Which seems makes some sense because same situation in exec() may also happen to show().
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 94f2059 
> 
> Diff: https://git.reviewboard.kde.org/r/125154/diff/
> 
> 
> Testing
> -------
> 
> So far I'm not able to reproduce 350758 for now.
> I uses lokalize merge file window to test since it's the easiest one for me to reproduce 350758.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150912/5bcd514e/attachment.html>