Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125145/
-----------------------------------------------------------

(Updated Sept. 10, 2015, 9:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

Submitted with commit 40d8500ab639a151b1655f6770493218bb2bf5ef by David Faure to branch master.


Repository: kservice


Description
-------

77a998e37 removed the call to KSycoca::disableAutoRebuild(),
we can just check that we are in kbuildsycoca using qAppName
like two other places in ksycoca.cpp already do.
And this way get rid of more unnecessary "public" API for ksycoca.

REVIEW: 125145


Diffs
-----

  src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 
  src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 

Diff: https://git.reviewboard.kde.org/r/125145/diff/


Testing
-------

compiles.

we don't have a unittest for a corrupt ksycoca file ;)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150910/7ebffa16/attachment-0001.html>