Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.

[David Faure]

> On Sept. 10, 2015, 8:39 p.m., Albert Astals Cid wrote:
> > What about removing s_autoRebuild and making KSycoca::disableAutoRebuild output a warning just in case someone weird out there is using it so they can get ready for KF6?

Good point, that's indeed the alternative. It's less behaviour-compatible, but for something marked as @internal and which only ever makes any difference on a corrupt database... nobody had any reason to call this indeed. Will do, thanks. And I should use the DEPRECATED macro too.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125145/#review85136
-----------------------------------------------------------


On Sept. 10, 2015, 8:31 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125145/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 8:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> 77a998e37 removed the call to KSycoca::disableAutoRebuild(),
> we can just check that we are in kbuildsycoca using qAppName
> like two other places in ksycoca.cpp already do.
> And this way get rid of more unnecessary "public" API for ksycoca.
> 
> 
> Diffs
> -----
> 
>   src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 
>   src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 
> 
> Diff: https://git.reviewboard.kde.org/r/125145/diff/
> 
> 
> Testing
> -------
> 
> compiles.
> 
> we don't have a unittest for a corrupt ksycoca file ;)
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150910/924396a6/attachment.html>