Review Request 125144: Provide enabled property for QIconItem.

Aleix Pol Gonzalez aleixpol at kde.org
Thu Sep 10 20:33:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125144/#review85135
-----------------------------------------------------------

Ship it!


Looks good.

How come this class is so undocumented? o.o

- Aleix Pol Gonzalez


On Sept. 10, 2015, 10:16 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125144/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 10:16 p.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Adds the standard boolean property "enabled" to the icon component.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.h e030ea294f247b2e9bd57f213fe272a20afa4afc 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 2a90c34318570aea52ca45ac701d73ef0083e2c2 
> 
> Diff: https://git.reviewboard.kde.org/r/125144/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150910/6f8f0e6f/attachment.html>


More information about the Kde-frameworks-devel mailing list