Review Request 125121: Move checkGlobalHeader() within KBuildSycoca::recreate().

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125121/
-----------------------------------------------------------

(Updated Sept. 10, 2015, 6:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

Submitted with commit 77a998e37bcd57908af79b96260f1577eb95d7fa by David Faure to branch master.


Repository: kservice


Description
-------

This leads to more self-contained API: recreate checks
if it can indeed reuse the existing sycoca or if it should skip it
(when language or $XDG_DATA_{HOME,DIRS} has changed)

And remove the call to clearCaches which closes KSycoca::self,
doesn't matter now that KBuildSycoca is a different instance anyway.


Diffs
-----

  src/kbuildsycoca/kbuildsycoca.h 65e4efb6d30ec57be1c5fd0d2a2b4dfcb7e760a7 
  src/kbuildsycoca/kbuildsycoca.cpp 3ce7ae425cfdfeac3264c5f4ecff440402402f7d 

Diff: https://git.reviewboard.kde.org/r/125121/diff/


Testing
-------

Wrote (and pushed) a new unittest (KSycocaTest::testOtherAppDir) for the case where kbuildsycoca detects a mismatch in the global header. Works before and after this patch.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150910/8beb2a82/attachment.html>