Review Request 125108: kbuildsycoca: remove code for --checkstamps and --nocheckfiles.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125108/
-----------------------------------------------------------

(Updated Sept. 10, 2015, 6:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

Submitted with commit b0c8fd8e64f6e02b781270e548c684a06e3e2948 by David Faure to branch master.


Repository: kservice


Description
-------

(the options are kept to avoid breaking hypothetic callers, but do nothing anymore)

--checkstamps was a timestamp comparison to find out if kbuildsycoca should
do nothing. Let's not just call it in that case ;) A similar timestamp check
is in ksycoca.cpp since recently.

--nocheckfiles was an experimental and marked dangerous option,
to speed up KDE startup by only checking the global header (lang and dirs),
but not checking for modified desktop files. I guess the idea was for
binary packages to always ensure that ksycoca is updated. That's a very
long term plan with a fdo desktop-file-index, but not really applicable until then
(what if you install something from sources, on a distro set up that way...).


Diffs
-----

  docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook 68e58db26262b7923adcdfc080bf18ffb7c805f6 
  src/kbuildsycoca/kbuildsycoca.cpp 3ce7ae425cfdfeac3264c5f4ecff440402402f7d 

Diff: https://git.reviewboard.kde.org/r/125108/diff/


Testing
-------

kservice unittests pass (but they don't really test these unused options ;)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150910/b73296c4/attachment.html>