Review Request 125115: kcmshell5 cookies: fix DBus names for kded5

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125115/#review85063
-----------------------------------------------------------

Ship it!


Yes, clearly.

I have plans to turn that kded module into library code (multiple processes sharing a file rather than a daemon), so we don't need a better solution for kded6 anyway ;)

- David Faure


On Sept. 9, 2015, 1:20 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125115/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 1:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> When starting this module, from the command line or similar, the error message is shown:
> 
> Unable to start the cookie handler service.
> You will not be able to manage the cookies that
> are stored on your computer.
> 
> and similarly for any operation attempted from the resulting dialogue.
> 
> The reason for this appears to be that the module is connecting to the DBus name 'org.kde.kded', which should now be 'org.kde.kded5' (verified with qdbusviewer and in kded/src/org.kde.kded5.service.in).  The patch here corrects these names throughout.
> 
> 
> Diffs
> -----
> 
>   src/kcms/kio/kcookiesmain.cpp c4e36ac 
>   src/kcms/kio/kcookiesmanagement.cpp c041fc2 
>   src/kcms/kio/kcookiespolicies.cpp 7470616 
>   src/kcms/kio/ksaveioconfig.cpp 82ca6d9 
> 
> Diff: https://git.reviewboard.kde.org/r/125115/diff/
> 
> 
> Testing
> -------
> 
> Built kio with these changes, cookie dialogue and management operates correctly.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150909/75bbcaf4/attachment.html>