Review Request 125051: KFileWidget: multiple files with ":" in filename recognized as directories

Aleix Pol Gonzalez aleixpol at kde.org
Sun Sep 6 17:47:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125051/#review84905
-----------------------------------------------------------



src/filewidgets/kfilewidget.cpp (line 901)
<https://git.reviewboard.kde.org/r/125051/#comment58740>

    User iterators for less look-ups?


Other than that, looks good to me.

- Aleix Pol Gonzalez


On Sept. 4, 2015, 11:32 p.m., Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125051/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 11:32 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 350696
>     https://bugs.kde.org/show_bug.cgi?id=350696
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> QUrl::toDisplayString removes password info by default. When using local files with ":" inside, toDisplayString returns empty filename
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfilewidget.cpp dc3c1f4 
> 
> Diff: https://git.reviewboard.kde.org/r/125051/diff/
> 
> 
> Testing
> -------
> 
> Patch fixes issue #350696, tested on my system, but maybe there is a better way to fix it ?
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150906/c7872685/attachment.html>


More information about the Kde-frameworks-devel mailing list