Review Request 125051: KFileWidget: multiple files with ":" in filename recognized as directories

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125051/#review84856
-----------------------------------------------------------


path() is wrong for local files on Windows, it should be toLocalFile() instead.

If the use of local paths should depend on the mode, like in your patch, then just use toLocalFile() instead of path().
If the use of local paths should depend on whether the URL is local or remote, use toDisplayString(QUrl::PreferLocalFile).

- David Faure


On Sept. 4, 2015, 8:29 p.m., Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125051/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 8:29 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 350696
>     https://bugs.kde.org/show_bug.cgi?id=350696
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> QUrl::toDisplayString removes password info by default. When using local files with ":" inside, toDisplayString returns empty filename
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfilewidget.cpp dc3c1f4 
> 
> Diff: https://git.reviewboard.kde.org/r/125051/diff/
> 
> 
> Testing
> -------
> 
> Patch fixes issue #350696, tested on my system, but maybe there is a better way to fix it ?
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150904/c938d908/attachment.html>