Review Request 125885: Support socks5 proxy in KTcpSocket

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125885/#review87773
-----------------------------------------------------------

Ship it!


This is clearly missing an "else" for other cases like an http proxy, can you add it, even without being able to test it?

In any case this is a clear improvement.

- David Faure


On Oct. 30, 2015, 11:26 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125885/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 11:26 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 342402
>     https://bugs.kde.org/show_bug.cgi?id=342402
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Automatically set socks5 proxy in KTcpSocket.
> 
> 
> Diffs
> -----
> 
>   src/core/ktcpsocket.h ffa3f0b 
>   src/core/ktcpsocket.cpp fde35a7 
> 
> Diff: https://git.reviewboard.kde.org/r/125885/diff/
> 
> 
> Testing
> -------
> 
> Test with akonadi imap agent, connect through socks5 proxy.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151031/fe92d560/attachment.html>