Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

[David Rosca]

> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote:
> > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how can I debug to ensure this is the case and not a local issue?
> 
> David Rosca wrote:
>     Broke in what way? Did you try if it works without this commit?
> 
> Luca Beltrame wrote:
>     I just reverted it and wheel scrolls again.
>     Broken as in, there is no wheel scrolling in (tested):
>     
>     - Kate
>     - Konversation
>     - Kontact
>     
>     But works in:
>     - Dolphin
> 
> David Rosca wrote:
>     It shouldn't break it, unless you have set 0 wheel scroll lines in mouse kcm. In the worst case, it should just ignore that value from kcm and use default 3 lines (but that is what this should be actually fixing).
> 
> Luca Beltrame wrote:
>     FYI, it's set to 3 lines there.

Ok, so can you add qDebug() << "wheelscrolllines" << m_hints[QPlatformTheme::WheelScrollLines]; after it is fetched from config and check it picks the correct value? (line 110 and 337 in khintssettings.cpp)
Also can you test if changing the wheel scroll lines value in mouse kcm and applying it fixes scrolling for running applications?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
-----------------------------------------------------------


On Oct. 29, 2015, 7:01 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
>     https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Use platform theme hint instead of manually using QApplication::setWheelScrollLines
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> -------
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151030/6871b6da/attachment-0001.html>