Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125691/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 6:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 1771412c7cf8a8d07af4fe2687e2a698e409d73b by David Rosca to branch master.


Repository: kio


Description
-------

If qMimeType is empty, addToMimeAppsList shouldn't be called.


Diffs
-----

  src/widgets/kopenwithdialog.cpp c60a193 

Diff: https://git.reviewboard.kde.org/r/125691/diff/


Testing
-------

opening new KOpenWithDialog() without mimeType and typing eg "dolphin" to exec line now correctly returns valid KService.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151029/60964710/attachment.html>