Review Request 125869: Convert all io slave .protocol data to json and embed it.

Christoph Cullmann cullmann at kde.org
Thu Oct 29 17:03:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 5:03 p.m.)


Review request for KDE Frameworks, Alex Richardson and David Faure.


Repository: kio


Description
-------

Convert all io slave .protocol data to json and embed it.
Allows easier deployment of the slaves.


Diffs
-----

  src/ioslaves/http/CMakeLists.txt 76a8e28 
  src/ioslaves/help/main_ghelp.cpp 59c8558 
  src/ioslaves/help/main.cpp 9939196 
  src/ioslaves/help/help.protocol 1deefe5 
  src/ioslaves/help/help.json PRE-CREATION 
  src/ioslaves/help/ghelp.protocol d2a642a 
  src/ioslaves/help/ghelp.json PRE-CREATION 
  src/ioslaves/help/CMakeLists.txt 867b59d 
  src/ioslaves/ftp/ftp.protocol 4c5f80c 
  src/ioslaves/ftp/ftp.json PRE-CREATION 
  src/ioslaves/ftp/ftp.cpp 382723a 
  src/ioslaves/ftp/CMakeLists.txt 04f5600 
  src/ioslaves/file/file.protocol 523c0f5 
  src/ioslaves/file/file.json PRE-CREATION 
  src/ioslaves/file/file.cpp 5ef1587 
  src/ioslaves/file/CMakeLists.txt cb85cfb 
  autotests/kprotocolinfotest.cpp fa3ad38 
  src/ioslaves/http/http.protocol 49e5dc5 
  src/ioslaves/http/https.protocol c15d06f 
  src/ioslaves/http/webdav.protocol 05c977a 
  src/ioslaves/http/webdavs.protocol d5e4b2f 
  src/ioslaves/trash/CMakeLists.txt 05161cd 
  src/ioslaves/trash/kio_trash.cpp cb23169 
  src/ioslaves/trash/trash.json PRE-CREATION 
  src/ioslaves/trash/trash.protocol 7430575 

Diff: https://git.reviewboard.kde.org/r/125869/diff/


Testing (updated)
-------

Tests still work (one needed patching, as the exec line contains now the full path).

Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151029/206839c6/attachment.html>


More information about the Kde-frameworks-devel mailing list