[kdeclarative] src/quickaddons: fix ciritical regression for QuickViewSharedEngine by commit 3792923639b1c480fd622f7d4d31f6f888c925b9

[David Faure]

On Thursday 22 October 2015 00:08:55 Takahiro Hashimoto wrote:
> Git commit 1c3f42afe17cc090372eaf45647d71495de12c19 by Takahiro Hashimoto.
> Committed on 22/10/2015 at 00:03.
> Pushed by hashimoto into branch 'master'.
> 
> fix ciritical regression for QuickViewSharedEngine by commit 3792923639b1c480fd622f7d4d31f6f888c925b9
> 
> view's item is not set if item's geometry is set by manual.

This looks like it broke the kdeclarative unittests, please investigate.

00:11:04 2/2 Test #2: quickviewsharedengine ............***Failed    1.73 sec
00:11:04 ********* Start testing of QuickViewSharedEngineTest *********
00:11:04 Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 4.9.2)
00:11:04 PASS   : QuickViewSharedEngineTest::initTestCase()
00:11:04 QWARN  : QuickViewSharedEngineTest::resizemodeitem() bbb QSize(300, 300)
00:11:04 QWARN  : QuickViewSharedEngineTest::resizemodeitem() ccc QSize(300, 300)
00:11:04 FAIL!  : QuickViewSharedEngineTest::resizemodeitem() Compared values are not the same
00:11:04    Actual   (view->initialSize()): QSize(0x0)
00:11:04    Expected (QSize(200, 200))    : QSize(200x200)
00:11:04    Loc: [/home/jenkins/builds/kdeclarative/kf5-qt5/autotests/quickviewsharedengine.cpp(175)]
00:11:04 PASS   : QuickViewSharedEngineTest::errors()
00:11:04 PASS   : QuickViewSharedEngineTest::engine()
00:11:04 PASS   : QuickViewSharedEngineTest::cleanupTestCase()
00:11:04 Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted
00:11:04 ********* Finished testing of QuickViewSharedEngineTest *********

https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/changes

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5