Review Request 125164: Finish killed KIO jobs

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/#review87562
-----------------------------------------------------------

Ship it!


Fix looks good, but the unittest can be cleaned up further.


autotests/jobtest.cpp (line 295)
<https://git.reviewboard.kde.org/r/125164/#comment60122>

    Where do you use this?



autotests/jobtest.cpp (line 297)
<https://git.reviewboard.kde.org/r/125164/#comment60121>

    still not needed ;)



autotests/jobtest.cpp (line 303)
<https://git.reviewboard.kde.org/r/125164/#comment60123>

    the &t capture is not needed anymore


- David Faure


On Oct. 23, 2015, 12:48 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125164/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 12:48 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Scheduler::jobFinished cleans up the job but doesn't report it as such.
> 
> 
> Diffs
> -----
> 
>   src/core/simplejob.cpp 3380cbe 
>   autotests/jobtest.cpp c24bcea 
>   autotests/jobtest.h ef8c3e1 
> 
> Diff: https://git.reviewboard.kde.org/r/125164/diff/
> 
> 
> Testing
> -------
> 
> Added a test and made it pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151029/15a47fce/attachment.html>