Review Request 125830: Read protocol info from plugin metadata

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125830/
-----------------------------------------------------------

(Updated Oct. 27, 2015, 10:31 p.m.)


Review request for KDE Frameworks, Alex Richardson and David Faure.


Changes
-------

Use key and slavePath for name and exec.
Is better, will avoid errors and ensures we use exactly the right kio slave as found during protocol info construction (as slavePath is full path there).


Repository: kio


Description
-------

Extends the protocol factory and co. to allow reading of protocol data from embedded json.
Allows to deploy io slaves without anything else than the io slave itself in librarypath kf5/kio.

I changed to factory to ALWAYS fill its cache for any request, as now the determination which protocols are around is more expensive than just some directory traversal.

If this preview is ok, I will do that for all other shipped slaves and update this request.


Diffs (updated)
-----

  src/core/kprotocolinfo.cpp 8a02f7a 
  src/core/kprotocolinfo_p.h c3dea6b 
  src/core/kprotocolinfofactory.cpp 29ba8f4 
  src/core/kprotocolinfofactory_p.h aa79fc5 
  src/ioslaves/http/http.cpp 1727d41 
  src/ioslaves/http/http.json PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125830/diff/


Testing
-------

http slave still seems to be found and work.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151027/e64c6f58/attachment-0001.html>