Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

[Heiko Becker]

> On Okt. 26, 2015, 10:03 nachm., Alex Merry wrote:
> > This shouldn't be necessary. I think the issue you're having is that you're giving the wrong arguments to CMake. Rather than using
> > 
> >     -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share
> > 
> > you should be using
> > 
> >     -DCMAKE_INSTALL_DATAROOTDIR:PATH=/usr/share
> > 
> > The "FULL" versions are calculated from the non-"FULL" ones. Perhaps I should make that clearer in the KDEInstallDirs documentation...

Indeed, I did misunderstand that part. However, my problem is caused by ${PACKAGE_PREFIX_DIR} in the cmake config file. Omitting ..._FULL_... doesn't change anything there.


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125819/#review87474
-----------------------------------------------------------


On Okt. 26, 2015, 8:40 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125819/
> -----------------------------------------------------------
> 
> (Updated Okt. 26, 2015, 8:40 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Two reasons to do this:
> - DBUS_INTERFACES_INSTALL_DIR is marked deprecated
> - It's helpful on a multiarch layout where the prefix is /usr/${host}
>   but arch-independent files should still be installed to /usr/share.
> 
> 
> Diffs
> -----
> 
>   src/api/KWallet/CMakeLists.txt 539b034d20a0e10ef7471bcc515b7b3885d617d6 
>   src/api/KWallet/KF5WalletConfig.cmake.in 82a18aa342d7e4abcde3fadec0b0dc802a2ef4ef 
> 
> Diff: https://git.reviewboard.kde.org/r/125819/diff/
> 
> 
> Testing
> -------
> 
> Successfully installed it with -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151027/c327aa31/attachment-0001.html>