Review Request 125800: OS X build and warning fix
Samuel Gaist
samuel.gaist at edeltech.ch
Mon Oct 26 14:18:58 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125800/
-----------------------------------------------------------
(Updated Oct. 26, 2015, 2:18 p.m.)
Review request for KDE Frameworks and Ivan Romanov.
Repository: qca
Description
-------
The cmake find file was missing, but CoreFoundation being a system
framework, no need to search for it.
OS X: Update code to not use deprecated functions/data structure
CSSM_DATA and SecCertificateGetData have been deprecated since 10.7.
This patch uses SecCertificateCopyData which is the official
replacement.
Diffs
-----
src/CMakeLists.txt a60bda0bf3d8bad7523ee7d50798c8cdb6c2eccb
src/qca_systemstore_mac.cpp 9349c90c8258d3d1f00a3796d93f94c09f5b1f2a
Diff: https://git.reviewboard.kde.org/r/125800/diff/
Testing
-------
Build on OS X 10.8
Check that qcatool-qt5 keystore list-stores returns the same results
Thanks,
Samuel Gaist
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151026/e7007fc3/attachment.html>
More information about the Kde-frameworks-devel
mailing list