Review Request 125784: fix windows compilation of autotests
Christoph Cullmann
cullmann at kde.org
Sun Oct 25 14:28:57 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125784/#review87368
-----------------------------------------------------------
Ship it!
It really doesn't compile, just ship it, better than broken build in any case.
- Christoph Cullmann
On Oct. 25, 2015, 8:20 a.m., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125784/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2015, 8:20 a.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> The #ifdefs skips the new symlink tests but did not prevent the usage of the new function which is #ifdef:ed out
>
>
> Diffs
> -----
>
> autotests/jobtest.cpp 4b3598d
>
> Diff: https://git.reviewboard.kde.org/r/125784/diff/
>
>
> Testing
> -------
>
> Compiles on windows again
>
>
> Thanks,
>
> Kåre Särs
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151025/6024e21b/attachment.html>
More information about the Kde-frameworks-devel
mailing list