Review Request 125778: Allow kio .protocol files to be app local and local kioslave deployment

Christoph Cullmann cullmann at kde.org
Sat Oct 24 19:06:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125778/
-----------------------------------------------------------

(Updated Oct. 24, 2015, 7:06 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

KIO http seems to work on mac now inside an application bundle ;=)


Summary (updated)
-----------------

Allow kio .protocol files to be app local and local kioslave deployment


Repository: kio


Description (updated)
-------

Allow .protocol files to be bundled with applications.
Search in app local paths first.
Side effect: protocols() result is now sorted by name and allProtocols won't create duplicated cache entries if .protocol files are duplicated

kioslave helper is search locally, too.

forkSlaves check was missing in holdSlave to avoid segfault without dbus.


Diffs (updated)
-----

  src/core/kprotocolinfofactory.cpp 29ba8f4 
  src/core/slave.cpp 9ce0d78 

Diff: https://git.reviewboard.kde.org/r/125778/diff/


Testing (updated)
-------

.protocol files are now found if bundled with the application
kwrite http://www.kde.org works on mac now.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151024/67224732/attachment.html>


More information about the Kde-frameworks-devel mailing list