Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125760/
-----------------------------------------------------------

(Updated Oct. 24, 2015, 1:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt.


Changes
-------

Submitted with commit b10bae68c7319cbb4e4e985e139702a15df7dcb8 by Christoph Cullmann to branch master.


Repository: kiconthemes


Description
-------

Allow icon themes to be embedded in applications and prefer the embedded ones, if e.g. Krita or Kate ships an embedded theme, that shall be found and used.
Qt does already do so, by searching in :/icons.


Diffs
-----

  autotests/CMakeLists.txt 707f39b 
  autotests/kiconloader_resourcethemetest.cpp PRE-CREATION 
  autotests/resources.qrc 5385977 
  src/kicontheme.cpp d0ab4b9 

Diff: https://git.reviewboard.kde.org/r/125760/diff/


Testing
-------

Themes still work, if you have the right theme in :/icons it is found, in contrast to before this patch.
Still a problem, that I need to takle in a different patch: How to enforce the use of some theme, Qt is able to do so via setThemeName, KIconLoader and Co. ignore that.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151024/7f245d1e/attachment.html>