Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125760/#review87303
-----------------------------------------------------------


Looks good to me. Maybe some testing would be useful?

- Aleix Pol Gonzalez


On Oct. 23, 2015, 8:25 a.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125760/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 8:25 a.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Allow icon themes to be embedded in applications and prefer the embedded ones, if e.g. Krita or Kate ships an embedded theme, that shall be found and used.
> Qt does already do so, by searching in :/icons.
> 
> 
> Diffs
> -----
> 
>   src/kicontheme.cpp d0ab4b9 
> 
> Diff: https://git.reviewboard.kde.org/r/125760/diff/
> 
> 
> Testing
> -------
> 
> Themes still work, if you have the right theme in :/icons it is found, in contrast to before this patch.
> Still a problem, that I need to takle in a different patch: How to enforce the use of some theme, Qt is able to do so via setThemeName, KIconLoader and Co. ignore that.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151023/ef407dcd/attachment.html>