Review Request 125164: Fix misbehavior when canceling a job

[Aleix Pol Gonzalez]

> On Oct. 22, 2015, 9:39 a.m., David Faure wrote:
> > autotests/jobtest.cpp, line 309
> > <https://git.reviewboard.kde.org/r/125164/diff/1/?file=402693#file402693line309>
> >
> >     What is the purpose of changing the currently-being-uploaded data buffer? Ah, from the fix I can see the purpose is to make it emit readyRead. Can you add a comment here like  "// make it emit readyRead..." if that's indeed the idea?
> >     
> >     (I assume this is to emulate something more like a socket?)

Correct, we originally spot this when testing KDE Connect transfers.


> On Oct. 22, 2015, 9:39 a.m., David Faure wrote:
> > src/core/transferjob.cpp, line 400
> > <https://git.reviewboard.kde.org/r/125164/diff/1/?file=402694#file402694line400>
> >
> >     Why slotFinished? Wouldn't just return be enough?
> >     kill() is supposed to take care of emitting finished already, and you don't want to emit it twice.

slotFinished is never called, if I remove the slotFinished call the test never ends.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/#review87245
-----------------------------------------------------------


On Sept. 11, 2015, 3:24 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125164/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 3:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Catch that the job has been cancelled and emit the job as finished.
> 
> Still, I'm not too sure it's the correct fix.
> 
> 
> Diffs
> -----
> 
>   autotests/jobtest.h ef8c3e1 
>   autotests/jobtest.cpp c24bcea 
>   src/core/transferjob.cpp 0c38070 
> 
> Diff: https://git.reviewboard.kde.org/r/125164/diff/
> 
> 
> Testing
> -------
> 
> Added a test and made it pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151023/ef5f3fed/attachment.html>